Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix and update translate strings #353

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Conversation

Zacharis278
Copy link
Contributor

@Zacharis278 Zacharis278 commented Apr 11, 2023

Two changes here:

  1. Make updates to the PII dialogue so that strings can be extracted for translation
  2. Extract updated translations. This hasn't been run in a while so there are a lot of strings out of date

Next steps:
Once this is in master well need to push all of this to transifex (🤞 that command works) and get the most needed strings translated. After that a follow up PR will be opened to pull down the translated strings.

@Zacharis278 Zacharis278 changed the title feat: update translations feat: fix and update translate strings Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1f1cc25) 97.68% compared to head (59293b4) 97.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files          77       77           
  Lines        6187     6187           
=======================================
  Hits         6044     6044           
  Misses        143      143           
Flag Coverage Δ
unittests 97.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lti_consumer/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Zacharis278 Zacharis278 merged commit 541bb36 into master Apr 12, 2023
@Zacharis278 Zacharis278 deleted the zhancock/translate branch April 12, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants